| 953c189 | Tim Peters | 12 August 2006, 05:17:41 UTC | Ah, fudge. One of the prints here actually "shouldn't be" protected by "if verbose:", which caused the test to fail on all non-Windows boxes. Note that I deliberately didn't convert this to unittest yet, because I expect it would be even harder to debug this on Tru64 after conversion. | 12 August 2006, 05:17:41 UTC |
| 1742f33 | Tim Peters | 12 August 2006, 04:42:47 UTC | test_signal: Signal handling on the Tru64 buildbot appears to be utterly insane. Plug some theoretical insecurities in the test script: - Verify that the SIGALRM handler was actually installed. - Don't call alarm() before the handler is installed. - Move everything that can fail inside the try/finally, so the test cleans up after itself more often. - Try sending all the expected signals in force_test_exit(), not just SIGALRM. Since that was fixed to actually send SIGALRM (instead of invisibly dying with an AttributeError), we've seen that sending SIGALRM alone does not stop this from hanging. - Move the "kill the child" business into the finally clause, so the child doesn't survive test failure to send SIGALRM to other tests later (there are also baffling SIGALRM-related failures in test_socket). - Cancel the alarm in the finally clause -- if the test dies early, we again don't want SIGALRM showing up to confuse a later test. Alas, this still relies on timing luck wrt the spawned script that sends the test signals, but it's hard to see how waiting for seconds can so often be so unlucky. test_threadedsignals: curiously, this test never fails on Tru64, but doesn't normally signal SIGALRM. Anyway, fixed an obvious (but probably inconsequential) logic error. | 12 August 2006, 04:42:47 UTC |
| ebcf875 | Neal Norwitz | 12 August 2006, 03:18:50 UTC | Verify verdat which is returned from malloc is not NULL. Ensure we don't pass NULL to free. Klocwork #306 (at least the first part, checking malloc) | 12 August 2006, 03:18:50 UTC |
| 0f7dbf7 | Neal Norwitz | 12 August 2006, 03:17:41 UTC | PyModule_GetDict() can fail, produce fatal errors if this happens on startup. Klocwork #298-299. | 12 August 2006, 03:17:41 UTC |
| b88cfad | Neal Norwitz | 12 August 2006, 03:16:54 UTC | Check return of PyMem_MALLOC (garbage) is non-NULL. Check seq in both portions of if/else. Klocwork #289-290. | 12 August 2006, 03:16:54 UTC |
| 5f17d9a | Neal Norwitz | 12 August 2006, 02:33:36 UTC | Don't deref v if it's NULL. Klocwork #214 | 12 August 2006, 02:33:36 UTC |
| 421c131 | Neal Norwitz | 12 August 2006, 02:12:30 UTC | Whoops, how did that get in there. :-) Revert all the parts of 51227 that were not supposed to go it. Only Modules/_ctypes/cfields.c was supposed to be changed | 12 August 2006, 02:12:30 UTC |
| 6b4953f | Neal Norwitz | 12 August 2006, 02:06:34 UTC | Check returned pointer is valid. Klocwork #233 | 12 August 2006, 02:06:34 UTC |
| b45f351 | Neal Norwitz | 12 August 2006, 01:57:47 UTC | I'm not sure why this code allocates this string for the error message. I think it would be better to always use snprintf and have the format limit the size of the name appropriately (like %.200s). Klocwork #340 | 12 August 2006, 01:57:47 UTC |
| ef0de02 | Neal Norwitz | 12 August 2006, 01:53:28 UTC | Try to handle a malloc failure. I'm not entirely sure this is correct. There might be something else we need to do to handle the exception. Klocwork # 212-213 | 12 August 2006, 01:53:28 UTC |
| 9cd3c34 | Neal Norwitz | 12 August 2006, 01:51:12 UTC | Move the assert which checks for a NULL pointer first. Klocwork #274. | 12 August 2006, 01:51:12 UTC |
| e0a81af | Neal Norwitz | 12 August 2006, 01:50:38 UTC | If _stat_float_times is false, we will try to INCREF ival which could be NULL. Return early in that case. The caller checks for PyErr_Occurred so this should be ok. Klocwork #297 | 12 August 2006, 01:50:38 UTC |
| 6bf1a8f | Neal Norwitz | 12 August 2006, 01:49:12 UTC | Handle NULL nodes while parsing. I'm not entirely sure this is correct. There might be something else that needs to be done to setup the error. Klocwork #295. | 12 August 2006, 01:49:12 UTC |
| edb2168 | Neal Norwitz | 12 August 2006, 01:47:59 UTC | This code is actually not used unless WITHOUT_COMPLEX is defined. However, there was no error checking that PyFloat_FromDouble returned a valid pointer. I believe this change is correct as it seemed to follow other code in the area. Klocwork # 292. | 12 August 2006, 01:47:59 UTC |
| 43bd4db | Neal Norwitz | 12 August 2006, 01:46:42 UTC | It's highly unlikely, though possible for PyEval_Get*() to return NULLs. So be safe and do an XINCREF. Klocwork # 221-222. | 12 August 2006, 01:46:42 UTC |
| 84167d0 | Neal Norwitz | 12 August 2006, 01:45:47 UTC | Even though _Py_Mangle() isn't truly public anyone can call it and there was no verification that privateobj was a PyString. If it wasn't a string, this could have allowed a NULL pointer to creep in below and crash. I wonder if this should be PyString_CheckExact? Must identifiers be strings or can they be subclasses? Klocwork #275 | 12 August 2006, 01:45:47 UTC |
| 6f5ff3f | Neal Norwitz | 12 August 2006, 01:43:40 UTC | Klocwork made another run and found a bunch more problems. This is the first batch of fixes that should be easy to verify based on context. This fixes problem numbers: 220 (ast), 323-324 (symtable), 321-322 (structseq), 215 (array), 210 (hotshot), 182 (codecs), 209 (etree). | 12 August 2006, 01:43:40 UTC |
| 2a899c8 | Thomas Heller | 11 August 2006, 19:55:35 UTC | When a ctypes C callback function is called, zero out the result storage before converting the result to C data. See the comment in the code for details. Provide a better context for errors when the conversion of a callback function's result cannot be converted. | 11 August 2006, 19:55:35 UTC |
| 975c8bb | Thomas Wouters | 11 August 2006, 15:02:39 UTC | Add ignore of *.pyc and *.pyo to Lib/xml/etree/. | 11 August 2006, 15:02:39 UTC |
| 0a7d1bb | Georg Brandl | 11 August 2006, 07:26:10 UTC | logging's atexit hook now runs even if the rest of the module has already been cleaned up. | 11 August 2006, 07:26:10 UTC |
| 368c155 | Georg Brandl | 11 August 2006, 07:15:38 UTC | Add Chris McDonough (latest cgi.py patch) | 11 August 2006, 07:15:38 UTC |
| 003c9e2 | Neal Norwitz | 11 August 2006, 06:09:41 UTC | Fix the failures on cygwin (2006-08-10 fixed the actual locking issue). The first hunk changes the colon to an ! like other Windows variants. We need to always wait on the child so the lock gets released and no other tests fail. This is the try/finally in the second hunk. | 11 August 2006, 06:09:41 UTC |
| 8b8c59c | Tim Peters | 11 August 2006, 03:49:10 UTC | force_test_exit(): This has been completely ineffective at stopping test_signal from hanging forever on the Tru64 buildbot. That could be because there's no such thing as signal.SIGALARM. Changed to the idiotic (but standard) signal.SIGALRM instead, and added some more debug output. | 11 August 2006, 03:49:10 UTC |
| 0857477 | Tim Peters | 11 August 2006, 00:49:01 UTC | test_PyThreadState_SetAsyncExc(): This is failing on some 64-bit boxes. I have no idea what the ctypes docs mean by "integers", and blind-guessing here that it intended to mean the signed C "int" type, in which case perhaps I can repair this by feeding the thread id argument to type ctypes.c_long(). Also made the worker thread daemonic, so it doesn't hang Python shutdown if the test continues to fail. | 11 August 2006, 00:49:01 UTC |
| b7ad1eb | Tim Peters | 10 August 2006, 23:22:13 UTC | Whitespace normalization broke test_cgi, because a line of quoted test data relied on preserving a single trailing blank. Changed the string from raw to regular, and forced in the trailing blank via an explicit \x20 escape. | 10 August 2006, 23:22:13 UTC |
| 0d9ca9f | Tim Peters | 10 August 2006, 22:48:45 UTC | Whitespace normalization. | 10 August 2006, 22:48:45 UTC |
| 4643c2f | Tim Peters | 10 August 2006, 22:45:34 UTC | Followup to bug #1069160. PyThreadState_SetAsyncExc(): internal correctness changes wrt refcount safety and deadlock avoidance. Also added a basic test case (relying on ctypes) and repaired the docs. | 10 August 2006, 22:45:34 UTC |
| 789c09d | Martin v. Löwis | 10 August 2006, 19:04:00 UTC | Update dangling references to the 3.2 database to mention that this is UCD 4.1 now. | 10 August 2006, 19:04:00 UTC |
| c69ac25 | Guido van Rossum | 10 August 2006, 18:09:25 UTC | Fix title -- it's rc1, not beta3. | 10 August 2006, 18:09:25 UTC |
| 133f4e4 | Guido van Rossum | 10 August 2006, 17:42:50 UTC | News item for SF bug 1112549. | 10 August 2006, 17:42:50 UTC |
| 9568b73 | Guido van Rossum | 10 August 2006, 17:41:07 UTC | Chris McDonough's patch to defend against certain DoS attacks on FieldStorage. SF bug #1112549. | 10 August 2006, 17:41:07 UTC |
| cd3d8be | Kurt B. Kaiser | 10 August 2006, 17:11:09 UTC | Retrieval of previous shell command was not always preserving indentation since 1.2a1) Patch 1528468 Tal Einat. | 10 August 2006, 17:11:09 UTC |
| b2dd1a3 | Tim Peters | 10 August 2006, 03:01:26 UTC | test_copytree_simple(): This was leaving behind two new temp directories each time it ran, at least on Windows. Several changes: explicitly closed all files; wrapped long lines; stopped suppressing errors when removing a file or directory fails (removing /shouldn't/ fail!); and changed what appeared to be incorrect usage of os.removedirs() (that doesn't remove empty directories at and /under/ the given path, instead it must be given an empty leaf directory and then deletes empty directories moving /up/ the path -- could be that the conceptually simpler shutil.rmtree() was really actually intended here). | 10 August 2006, 03:01:26 UTC |
| 1fe9ca0 | Kurt B. Kaiser | 10 August 2006, 01:41:17 UTC | Changing tokenize (39046) to detect dedent broke tabnanny check (since 1.2a1) | 10 August 2006, 01:41:17 UTC |
| 388b3a6 | Tim Peters | 10 August 2006, 00:58:49 UTC | Add missing svn:eol-style property to text files. | 10 August 2006, 00:58:49 UTC |
| 73f12a3 | Martin v. Löwis | 09 August 2006, 23:42:18 UTC | Add some commentary on -mimpure-text. | 09 August 2006, 23:42:18 UTC |
| 53f2b5f | Kurt B. Kaiser | 09 August 2006, 20:34:46 UTC | ToggleTab dialog was setting indent to 8 even if cancelled (since 1.2a1). | 09 August 2006, 20:34:46 UTC |
| faeeab7 | Andrew M. Kuchling | 09 August 2006, 18:23:14 UTC | Typo fix | 09 August 2006, 18:23:14 UTC |
| be332e4 | Kurt B. Kaiser | 09 August 2006, 17:47:15 UTC | As a slight enhancement to the previous checkin, improve the internal error reporting by moving message to IDLE console. | 09 August 2006, 17:47:15 UTC |
| 312e5af | Kurt B. Kaiser | 09 August 2006, 16:46:15 UTC | 1. When used w/o subprocess, all exceptions were preceeded by an error message claiming they were IDLE internal errors (since 1.2a1). 2. Add Ronald Oussoren to CREDITS M NEWS.txt M PyShell.py M CREDITS.txt | 09 August 2006, 16:46:15 UTC |
| 97ff047 | Armin Rigo | 09 August 2006, 15:37:26 UTC | Concatenation on a long string breaks (SF #1526585). | 09 August 2006, 15:37:26 UTC |
| c95f756 | Ronald Oussoren | 09 August 2006, 14:56:33 UTC | It's unlikely that future versions will require _POSIX_C_SOURCE | 09 August 2006, 14:56:33 UTC |
| 51fc8c4 | Armin Rigo | 09 August 2006, 14:55:26 UTC | Fix and test for an infinite C recursion. | 09 August 2006, 14:55:26 UTC |
| 98c0480 | Andrew M. Kuchling | 09 August 2006, 14:06:19 UTC | Reindent code | 09 August 2006, 14:06:19 UTC |
| 58aa6f7 | Andrew M. Kuchling | 09 August 2006, 14:05:35 UTC | Add missing 'self' parameters | 09 August 2006, 14:05:35 UTC |
| 13300f2 | Andrew M. Kuchling | 09 August 2006, 13:57:05 UTC | [Patch #1534027] Add notes on locale module changes | 09 August 2006, 13:57:05 UTC |
| b713660 | Andrew M. Kuchling | 09 August 2006, 13:03:41 UTC | [Bug #1536021] Mention __hash__ change | 09 August 2006, 13:03:41 UTC |
| ab2f8f7 | Martin v. Löwis | 09 August 2006, 07:57:39 UTC | __hash__ may now return long int; the final hash value is obtained by invoking hash on the long int. Fixes #1536021. | 09 August 2006, 07:57:39 UTC |
| 209307e | Georg Brandl | 09 August 2006, 07:03:22 UTC | Introduce an upper bound on tuple nesting depth in C argument format strings; fixes rest of #1523610. | 09 August 2006, 07:03:22 UTC |
| 8e24a96 | Tim Peters | 09 August 2006, 00:52:26 UTC | Whitespace normalization. | 09 August 2006, 00:52:26 UTC |
| 7572f03 | Georg Brandl | 08 August 2006, 20:48:10 UTC | ``str`` is now the same object as ``types.StringType``. | 08 August 2006, 20:48:10 UTC |
| 7f719c5 | Georg Brandl | 08 August 2006, 20:13:13 UTC | Bug #1536660: separate two words. | 08 August 2006, 20:13:13 UTC |
| 6c223fe | Georg Brandl | 08 August 2006, 20:11:22 UTC | Bug #1536828: typo: TypeType should have been StringType. | 08 August 2006, 20:11:22 UTC |
| 4f71b55 | Andrew M. Kuchling | 08 August 2006, 19:00:34 UTC | Bump version number | 08 August 2006, 19:00:34 UTC |
| a977130 | Andrew M. Kuchling | 08 August 2006, 19:00:14 UTC | 'Other changes' section now has only one item; move the item elsewhere and remove the section | 08 August 2006, 19:00:14 UTC |
| 88eb45f | Andrew M. Kuchling | 08 August 2006, 18:56:08 UTC | Move obmalloc item into C API section | 08 August 2006, 18:56:08 UTC |
| 30c0d1d | Andrew M. Kuchling | 08 August 2006, 18:50:14 UTC | Reword paragraph to clarify | 08 August 2006, 18:50:14 UTC |
| dc68ffd | Thomas Heller | 08 August 2006, 17:39:20 UTC | Remove accidently committed, duplicated test. | 08 August 2006, 17:39:20 UTC |
| ab1049c | Thomas Heller | 08 August 2006, 17:37:00 UTC | memcmp() can return values other than -1, 0, and +1 but tp_compare must not. | 08 August 2006, 17:37:00 UTC |
| b0061c8 | Georg Brandl | 08 August 2006, 11:56:21 UTC | Remove "non-mapping" and "non-sequence" from TypeErrors raised by PyMapping_Size and PySequence_Size. Because len() tries first sequence, then mapping size, it will always raise a "non-mapping object has no len" error which is confusing. | 08 August 2006, 11:56:21 UTC |
| f3321b5 | Georg Brandl | 08 August 2006, 11:52:34 UTC | webbrowser: Silence stderr output if no gconftool or gnome browser found | 08 August 2006, 11:52:34 UTC |
| 8607042 | Andrew M. Kuchling | 06 August 2006, 22:07:04 UTC | [Patch #1464056] Ensure that we use the panelw library when linking with ncursesw. Once I see how the buildbots react, I'll backport this to 2.4. | 06 August 2006, 22:07:04 UTC |
| 16ee33a | Andrew MacIntyre | 06 August 2006, 12:37:03 UTC | test_threading now skips testing alternate thread stack sizes on platforms that don't support changing thread stack size. | 06 August 2006, 12:37:03 UTC |
| d336e98 | Georg Brandl | 06 August 2006, 09:17:16 UTC | Don't produce output in test_builtin. | 06 August 2006, 09:17:16 UTC |
| 7e3ba2a | Georg Brandl | 06 August 2006, 08:23:54 UTC | Bug #1535165: fixed a segfault in input() and raw_input() when sys.stdin is closed. | 06 August 2006, 08:23:54 UTC |
| 534fe18 | Georg Brandl | 06 August 2006, 07:26:21 UTC | Bug #1535081: A leading underscore has been added to the names of the md5 and sha modules, so add it in Modules/Setup.dist too. | 06 August 2006, 07:26:21 UTC |
| 9908d16 | Georg Brandl | 06 August 2006, 07:06:33 UTC | Bug #1535182: really test the xreadlines() method of bz2 objects. | 06 August 2006, 07:06:33 UTC |
| 212b587 | Georg Brandl | 05 August 2006, 06:10:54 UTC | Patch #1534922: correct and enhance unittest docs. | 05 August 2006, 06:10:54 UTC |
| e6c9f98 | Bob Ippolito | 04 August 2006, 23:59:21 UTC | Fix #1530559, struct.pack raises TypeError where it used to convert. Passing float arguments to struct.pack when integers are expected now triggers a DeprecationWarning. | 04 August 2006, 23:59:21 UTC |
| b1ccc4d | Tim Peters | 04 August 2006, 22:00:35 UTC | Whitespace normalization. | 04 August 2006, 22:00:35 UTC |
| f4152c3 | Andrew M. Kuchling | 04 August 2006, 21:10:03 UTC | Fix mangled sentence | 04 August 2006, 21:10:03 UTC |
| 0067b5f | Andrew M. Kuchling | 04 August 2006, 20:37:43 UTC | Typo fixes | 04 August 2006, 20:37:43 UTC |
| db7b443 | Thomas Heller | 04 August 2006, 19:49:31 UTC | Fix #1534738: win32 debug version of _msi must be _msi_d.pyd, not _msi.pyd. Fix the name of the pdb file as well. | 04 August 2006, 19:49:31 UTC |
| 1798489 | Thomas Heller | 04 August 2006, 18:57:34 UTC | Fix #1530448 - fix ctypes build failure on solaris 10. The '-mimpure-text' linker flag is required when linking _ctypes.so. | 04 August 2006, 18:57:34 UTC |
| 74d36f0 | Thomas Heller | 04 August 2006, 18:17:40 UTC | On Windows, make PyErr_Warn an exported function again. | 04 August 2006, 18:17:40 UTC |
| 1618363 | Georg Brandl | 04 August 2006, 18:07:34 UTC | Better fix for bug #1531405, not executing str(value) twice. | 04 August 2006, 18:07:34 UTC |
| e9462c7 | Georg Brandl | 04 August 2006, 18:03:37 UTC | Change fix for segfaulting property(), add a NEWS entry and a test. | 04 August 2006, 18:03:37 UTC |
| 06ded09 | Neil Schemenauer | 04 August 2006, 16:20:30 UTC | Fix the 'compiler' package to generate correct code for MAKE_CLOSURE. In the 2.5 development cycle, MAKE_CLOSURE as changed to take free variables as a tuple rather than as individual items on the stack. Closes patch #1534084. | 04 August 2006, 16:20:30 UTC |
| 4538193 | Georg Brandl | 04 August 2006, 06:03:53 UTC | Fix bug caused by first decrefing, then increfing. | 04 August 2006, 06:03:53 UTC |
| d856ce0 | Gregory P. Smith | 04 August 2006, 05:17:47 UTC | fix typos | 04 August 2006, 05:17:47 UTC |
| 7a36f5f | Fred Drake | 04 August 2006, 05:17:21 UTC | SF patch #1534048 (bug #1531003): fix typo in error message | 04 August 2006, 05:17:21 UTC |
| 9a70f95 | Neal Norwitz | 04 August 2006, 05:12:19 UTC | There were really two issues | 04 August 2006, 05:12:19 UTC |
| 0cbd805 | Neal Norwitz | 04 August 2006, 05:09:28 UTC | Bug #1333982: string/number constants were inappropriately stored in the byte code and co_consts even if they were not used, ie immediately popped off the stack. | 04 August 2006, 05:09:28 UTC |
| 4ffedad | Neal Norwitz | 04 August 2006, 04:58:47 UTC | Bug #1191458: tracing over for loops now produces a line event on each iteration. I'm not positive this is the best way to handle this. I'm also not sure that there aren't other cases where the lnotab is generated incorrectly. It would be great if people that use pdb or tracing could test heavily. Also: * Remove dead/duplicated code that wasn't used/necessary because we already handled the docstring prior to entering the loop. * add some debugging code into the compiler (#if 0'd out). | 04 August 2006, 04:58:47 UTC |
| ff4b63b | Neal Norwitz | 04 August 2006, 04:50:21 UTC | Bug #1531405, format_exception no longer raises an exception if str(exception) raised an exception. | 04 August 2006, 04:50:21 UTC |
| 4b8bd31 | Anthony Baxter | 03 August 2006, 00:21:45 UTC | Tagging for release of Python 2.5b3 | 03 August 2006, 00:21:45 UTC |
| 54e3cf0 | Tim Peters | 02 August 2006, 18:19:35 UTC | Add missing svn:eol-style property to text files. | 02 August 2006, 18:19:35 UTC |
| 961b91b | Martin v. Löwis | 02 August 2006, 13:53:55 UTC | Correction of patch #1455898: In the mbcs decoder, set final=False for stream decoder, but final=True for the decode function. | 02 August 2006, 13:53:55 UTC |
| 5c387f2 | Thomas Heller | 02 August 2006, 12:00:13 UTC | Fix a mistake. | 02 August 2006, 12:00:13 UTC |
| 6a0ce40 | Thomas Heller | 02 August 2006, 11:35:31 UTC | A few nore words about what ctypes does. Document that using the wrong calling convention can also raise 'ValueError: Procedure called with the wrong number of arguments'. | 02 August 2006, 11:35:31 UTC |
| 5d32a9f | Anthony Baxter | 02 August 2006, 07:43:09 UTC | pre-release machinations | 02 August 2006, 07:43:09 UTC |
| 30eb966 | Neal Norwitz | 02 August 2006, 07:09:32 UTC | Add some explanation about Klocwork and Coverity static analysis | 02 August 2006, 07:09:32 UTC |
| 9b0ca79 | Neal Norwitz | 02 August 2006, 06:46:21 UTC | Patch #1519025 and bug #926423: If a KeyboardInterrupt occurs during a socket operation on a socket with a timeout, the exception will be caught correctly. Previously, the exception was not caught. | 02 August 2006, 06:46:21 UTC |
| 3ee5941 | Neal Norwitz | 02 August 2006, 06:19:19 UTC | Let us know when there was a problem and the child had to kill the parent | 02 August 2006, 06:19:19 UTC |
| c0328d1 | Neal Norwitz | 02 August 2006, 06:15:10 UTC | v is already checked for NULL, so just DECREF it | 02 August 2006, 06:15:10 UTC |
| c5e060d | Neal Norwitz | 02 August 2006, 06:14:22 UTC | _PyWeakref_GetWeakrefCount() now returns a Py_ssize_t instead of long. | 02 August 2006, 06:14:22 UTC |
| 5fb9c20 | Ronald Oussoren | 02 August 2006, 06:10:10 UTC | Updated documentation for the script that builds the OSX installer. | 02 August 2006, 06:10:10 UTC |
| a05f6e2 | Tim Peters | 02 August 2006, 05:20:08 UTC | _Stream.close(): Try to kill struct.pack() warnings when writing the crc to file on the "PPC64 Debian trunk" buildbot when running test_tarfile. This is again a case where the native zlib crc is an unsigned 32-bit int, but the Python wrapper implicitly casts it to signed C long, so that "the sign bit looks different" on different platforms. | 02 August 2006, 05:20:08 UTC |
| 99dfe3c | Neal Norwitz | 02 August 2006, 04:27:11 UTC | Prevent memory leak on error. Reported by Klocwork #36 | 02 August 2006, 04:27:11 UTC |
| 62decc9 | Tim Peters | 02 August 2006, 04:12:36 UTC | Try to squash struct.pack warnings on the "amd64 gentoo trunk" buildbot (& possibly other 64-bit boxes) during test_gzip. The native zlib crc32 function returns an unsigned 32-bit integer, which the Python wrapper implicitly casts to C long. Therefore the same crc can "look negative" on a 32-bit box but "look positive" on a 64-bit box. This patch papers over that platform difference when writing the crc to file. It may be better to change the Python wrapper, either to make the result "look positive" on all platforms (which means it may have to return a Python long at times on a 32-bit box), or to keep the sign the same across boxes. But that would be a visible change in what users see, while the current hack changes no visible behavior (well, apart from stopping the struct deprecation warning). Note that the module-level write32() function is no longer used. | 02 August 2006, 04:12:36 UTC |
